Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Unit and Snapshot tests for top banner on Secure Conversation #1135

Closed
wants to merge 1 commit into from
Closed

Add Unit and Snapshot tests for top banner on Secure Conversation #1135

wants to merge 1 commit into from

Conversation

ykyivskyi-gl
Copy link
Contributor

What was solved?
This PR adds unit and snapshot tests for top banner on Secure Conversation
Release notes:

  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from iOS SDKs → Things to consider for newly added logs in Confluence for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorkravchenko igorkravchenko Awaiting requested review from igorkravchenko

@EgorovEI EgorovEI Awaiting requested review from EgorovEI

@rasmustautsglia rasmustautsglia Awaiting requested review from rasmustautsglia

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ykyivskyi-gl